I will answer however my views might not count as D is about the graduate with her PGCE which lets her teach in primary, high school, and beyond.
To me, what makes a great teacher:
Patience
A sense of humor
Dedication
So there to teach but have a bit of humor at the same time. To want to help kids but not focus solely on them. Someone who gets everyone’s attention and is unique but at the same time firm. So you know you can joke but you have to do the work to be able to,
The last time I had a teacher like that was in Primary school. She’s dead now but the memory lives on Mrs Short.